Review finding 13/19 · conventional-comment issue (i18n) · area binder · gate: decide before the v1 API freeze
To add once they exist: label binder; milestone v1. (Already applied: enhancement, documentation.)
Problem
The binder's public messages (the public and detailed messages of REQUEST_ARGUMENT_REQUIRED / REQUEST_ARGUMENT_INVALID) are hardcoded English string literals with no localization hook — unlike the rest of the library, whose canonical pattern localizes messages (the Usage sample ships five languages).
Impact
A consumer serving non-English clients cannot localize the binder's structural error messages, breaking the library's own i18n story at the primary-adapter boundary — the one place client-facing text matters most.
Direction
Route the messages through resources (.resx) or a localization hook in RequestBinderOptions, consistent with the library's i18n pattern. At minimum, document that these messages are English-only and how to override them.
Context
Surfaced by the RequestBinder review (design spec #126, shipped in #141). Finding 13 of 19.
See doc/Internationalization.en.md for the library's i18n pattern.
Problem
The binder's public messages (the public and detailed messages of
REQUEST_ARGUMENT_REQUIRED/REQUEST_ARGUMENT_INVALID) are hardcoded English string literals with no localization hook — unlike the rest of the library, whose canonical pattern localizes messages (theUsagesample ships five languages).Impact
A consumer serving non-English clients cannot localize the binder's structural error messages, breaking the library's own i18n story at the primary-adapter boundary — the one place client-facing text matters most.
Direction
Route the messages through resources (
.resx) or a localization hook inRequestBinderOptions, consistent with the library's i18n pattern. At minimum, document that these messages are English-only and how to override them.Context
Surfaced by the RequestBinder review (design spec #126, shipped in #141). Finding 13 of 19.
See
doc/Internationalization.en.mdfor the library's i18n pattern.