Skip to content

Fix Very Vanilla MQ path validation#33

Open
Teichoui wants to merge 1 commit into
RedGuides:mainfrom
Teichoui:codex/issue-22-vv-path-rg-clean
Open

Fix Very Vanilla MQ path validation#33
Teichoui wants to merge 1 commit into
RedGuides:mainfrom
Teichoui:codex/issue-22-vv-path-rg-clean

Conversation

@Teichoui

@Teichoui Teichoui commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes Very Vanilla MQ path validation so relative packaged defaults are allowed, while absolute paths that point under an EverQuest folder containing eqgame.exe still hard-error clearly.

Why

RedFetch needs the MacroQuest folder, not an EverQuest executable path. This preserves bundled relative special-resource defaults while still catching user-selected invalid absolute MQ paths early.

Details

  • Only runs eqgame.exe parent validation for absolute special-resource paths.
  • Adds tests for relative defaults and absolute invalid Very Vanilla MQ paths.

Validation

  • uv run --with pytest pytest tests/test_config_validation.py
  • uv run --with pytest --with pytest-mock pytest
  • python -m compileall -q src tests
  • git diff --check origin/main...HEAD

Related to #22

@Teichoui Teichoui marked this pull request as ready for review June 8, 2026 20:29
@brainiac

brainiac commented Jun 8, 2026

Copy link
Copy Markdown

I'm confused why a path being relative somehow makes it OK to have eqgame.exe in its path.

The association between relative and absolute pathes and the safety of having eqgame.exe in a particular location isn't documented, if there is any at all.

This reads more to me like the path that has eqgame.exe in it happens to be a relative path.

What if EQ is on the desktop and MQ is installed inside of it and its a relative path?

@brainiac

brainiac commented Jun 8, 2026

Copy link
Copy Markdown

RedFetch needs the MacroQuest folder, not an EverQuest executable path. This preserves bundled relative special-resource defaults while still catching user-selected invalid absolute MQ paths early.

I read this like 5 times and still don't understand what this means. Can you explain it to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants