Fix Very Vanilla MQ path validation#33
Open
Teichoui wants to merge 1 commit into
Open
Conversation
|
I'm confused why a path being relative somehow makes it OK to have eqgame.exe in its path. The association between relative and absolute pathes and the safety of having eqgame.exe in a particular location isn't documented, if there is any at all. This reads more to me like the path that has eqgame.exe in it happens to be a relative path. What if EQ is on the desktop and MQ is installed inside of it and its a relative path? |
I read this like 5 times and still don't understand what this means. Can you explain it to me? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Very Vanilla MQ path validation so relative packaged defaults are allowed, while absolute paths that point under an EverQuest folder containing
eqgame.exestill hard-error clearly.Why
RedFetch needs the MacroQuest folder, not an EverQuest executable path. This preserves bundled relative special-resource defaults while still catching user-selected invalid absolute MQ paths early.
Details
eqgame.exeparent validation for absolute special-resource paths.Validation
uv run --with pytest pytest tests/test_config_validation.pyuv run --with pytest --with pytest-mock pytestpython -m compileall -q src testsgit diff --check origin/main...HEADRelated to #22