From 01065aa1dbe6eca7310e6f113914c8c0caa077fa Mon Sep 17 00:00:00 2001 From: LocalIdentity Date: Tue, 28 Jul 2026 21:28:32 +1000 Subject: [PATCH] Fix Herald Skills not scaling area with some tree nodes The `Spell Skills` wording was only matching to skills that dealt spell damage instead of having the spell tag Herald skills are all spell gems but don't deal spell damage so the `Spell skills have` nodes were never applying to them --- src/Data/ModCache.lua | 8 ++++---- src/Modules/ModParser.lua | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Data/ModCache.lua b/src/Data/ModCache.lua index dfdc865eb2..6991016144 100755 --- a/src/Data/ModCache.lua +++ b/src/Data/ModCache.lua @@ -12122,10 +12122,10 @@ c["Spell Critical Strike Chance Bifurcates"]={{[1]={flags=2,keywordFlags=0,name= c["Spell Skills always deal Critical Strikes on final Repeat"]={{[1]={flags=2,keywordFlags=0,name="SpellSkillsAlwaysDealCriticalStrikesOnFinalRepeat",type="FLAG",value=true}},nil} c["Spell Skills cannot deal Critical Strikes except on final Repeat"]={{[1]={flags=2,keywordFlags=0,name="SpellSkillsCannotDealCriticalStrikesExceptOnFinalRepeat",type="FLAG",value=true},[2]={[1]={type="Condition",var="alwaysFinalRepeat"},flags=0,keywordFlags=0,name="",type="FLAG",value=true}},nil} c["Spell Skills deal no Damage"]={{[1]={[1]={skillType=2,type="SkillType"},flags=0,keywordFlags=0,name="DealNoDamage",type="FLAG",value=true}},nil} -c["Spell Skills have +12% to Damage over Time Multiplier for Poison"]={{[1]={flags=0,keywordFlags=1075970048,name="DotMultiplier",type="BASE",value=12}},nil} -c["Spell Skills have +5% to Damage over Time Multiplier for Poison"]={{[1]={flags=0,keywordFlags=1075970048,name="DotMultiplier",type="BASE",value=5}},nil} -c["Spell Skills have 10% increased Area of Effect"]={{[1]={flags=0,keywordFlags=131072,name="AreaOfEffect",type="INC",value=10}},nil} -c["Spell Skills have 20% increased Area of Effect"]={{[1]={flags=0,keywordFlags=131072,name="AreaOfEffect",type="INC",value=20}},nil} +c["Spell Skills have +12% to Damage over Time Multiplier for Poison"]={{[1]={[1]={skillType=2,type="SkillType"},flags=0,keywordFlags=1075838976,name="DotMultiplier",type="BASE",value=12}},nil} +c["Spell Skills have +5% to Damage over Time Multiplier for Poison"]={{[1]={[1]={skillType=2,type="SkillType"},flags=0,keywordFlags=1075838976,name="DotMultiplier",type="BASE",value=5}},nil} +c["Spell Skills have 10% increased Area of Effect"]={{[1]={[1]={skillType=2,type="SkillType"},flags=0,keywordFlags=0,name="AreaOfEffect",type="INC",value=10}},nil} +c["Spell Skills have 20% increased Area of Effect"]={{[1]={[1]={skillType=2,type="SkillType"},flags=0,keywordFlags=0,name="AreaOfEffect",type="INC",value=20}},nil} c["Spells Cast by Totems have 4% increased Cast Speed"]={{[1]={flags=18,keywordFlags=16384,name="Speed",type="INC",value=4}},nil} c["Spells Cast by Totems have 5% increased Cast Speed"]={{[1]={flags=18,keywordFlags=16384,name="Speed",type="INC",value=5}},nil} c["Spells Cast by Totems have 8% increased Cast Speed"]={{[1]={flags=18,keywordFlags=16384,name="Speed",type="INC",value=8}},nil} diff --git a/src/Modules/ModParser.lua b/src/Modules/ModParser.lua index 3a69a817b3..6655ccb3d2 100644 --- a/src/Modules/ModParser.lua +++ b/src/Modules/ModParser.lua @@ -1182,7 +1182,7 @@ local preFlagList = { ["^attacks [hd][ae][va][el] "] = { flags = ModFlag.Attack }, ["^attack skills [hd][ae][va][el] "] = { keywordFlags = KeywordFlag.Attack }, ["^spells [hd][ae][va][el] a? ?"] = { flags = ModFlag.Spell }, - ["^spell skills [hd][ae][va][el] "] = { keywordFlags = KeywordFlag.Spell }, + ["^spell skills [hd][ae][va][el] "] = { tag = { type = "SkillType", skillType = SkillType.Spell } }, ["^projectile attack skills [hd][ae][va][el] "] = { tag = { type = "SkillType", skillType = SkillType.RangedAttack } }, ["^projectiles from attacks [hd][ae][va][el] "] = { tag = { type = "SkillType", skillType = SkillType.RangedAttack } }, ["^arrows [hd][ae][va][el] "] = { keywordFlags = KeywordFlag.Arrow },