From 7cc1a21f3ea2d350d6bb6c6a0ca3cf76b3fc0186 Mon Sep 17 00:00:00 2001
From: ddelpiano <dario@metacell.us>
Date: Tue, 26 May 2026 18:07:24 +0200
Subject: [PATCH] fixing issues noticed during review

---
 src/components/Auth/Register.jsx              | 12 +++
 .../TermEditor/newTerm/FirstStepContent.jsx   | 77 ++++++++++---------
 2 files changed, 52 insertions(+), 37 deletions(-)

diff --git a/src/components/Auth/Register.jsx b/src/components/Auth/Register.jsx
index c110fe51..5c35ca36 100644
--- a/src/components/Auth/Register.jsx
+++ b/src/components/Auth/Register.jsx
@@ -243,6 +243,18 @@ const Register = () => {
                   isRequired
                 />
               </Grid>
+              <Grid item xs={12}>
+                <PasswordField
+                  label="Confirm Password"
+                  placeholder="Confirm your password"
+                  value={formData.confirmPassword}
+                  onChange={(e) =>
+                    setFormData({ ...formData, confirmPassword: e.target.value })
+                  }
+                  errorMessage={errors.confirmPassword}
+                  isRequired
+                />
+              </Grid>
               <Grid item xs={12}>
                 <FormControl>
                   <Button
diff --git a/src/components/TermEditor/newTerm/FirstStepContent.jsx b/src/components/TermEditor/newTerm/FirstStepContent.jsx
index 274dd151..8b739387 100644
--- a/src/components/TermEditor/newTerm/FirstStepContent.jsx
+++ b/src/components/TermEditor/newTerm/FirstStepContent.jsx
@@ -1,5 +1,5 @@
 import PropTypes from "prop-types";
-import { useState, useEffect, useContext } from "react";
+import { useState, useCallback, useEffect, useContext } from "react";
 import { debounce } from "lodash";
 import {
     Box,
@@ -67,50 +67,53 @@ const FirstStepContent = ({ term, type, existingIds, synonyms, handleTermChange,
     const { user, updateStoredSearchTerm } = useContext(GlobalDataContext);
     const navigate = useNavigate();
 
-    const searchForMatches = debounce(async (searchTerm, type) => {
-        if (!searchTerm || !type) {
-            setTermResults([]);
-            setHasExactMatch(false);
-            return;
-        }
+    const searchForMatches = useCallback(
+        debounce(async (searchTerm, type) => {
+            if (!searchTerm || !type) {
+                setTermResults([]);
+                setHasExactMatch(false);
+                return;
+            }
 
-        setLoading(true);
+            setLoading(true);
 
-        try {
-            const response = await elasticSearch(searchTerm, 10);
-            const rawResults = response.results.results || [];
+            try {
+                const response = await elasticSearch(searchTerm, 10);
+                const rawResults = response.results.results || [];
 
-            const filteredResults = rawResults.filter(result => {
-                return result.type === type.toLowerCase() ||
-                    (result.type === "term") ||
-                    (result.type === "relationship") ||
-                    (result.type === "ontology");
-            });
+                const filteredResults = rawResults.filter(result => {
+                    return result.type === type.toLowerCase() ||
+                        (result.type === "term") ||
+                        (result.type === "relationship") ||
+                        (result.type === "ontology");
+                });
 
-            const exactMatch = filteredResults.find(result =>
-                result.label?.toLowerCase() === searchTerm.toLowerCase() &&
-                result.type === type.toLowerCase()
-            );
+                const exactMatch = filteredResults.find(result =>
+                    result.label?.toLowerCase() === searchTerm.toLowerCase() &&
+                    result.type === type.toLowerCase()
+                );
 
-            setHasExactMatch(!!exactMatch);
+                setHasExactMatch(!!exactMatch);
 
-            const sortedResults = filteredResults.sort((a, b) => {
-                const aIsExact = a.label?.toLowerCase() === searchTerm.toLowerCase();
-                const bIsExact = b.label?.toLowerCase() === searchTerm.toLowerCase();
+                const sortedResults = filteredResults.sort((a, b) => {
+                    const aIsExact = a.label?.toLowerCase() === searchTerm.toLowerCase();
+                    const bIsExact = b.label?.toLowerCase() === searchTerm.toLowerCase();
 
-                if (aIsExact && !bIsExact) return -1;
-                if (!aIsExact && bIsExact) return 1;
-                return 0;
-            });
+                    if (aIsExact && !bIsExact) return -1;
+                    if (!aIsExact && bIsExact) return 1;
+                    return 0;
+                });
 
-            setTermResults(sortedResults);
-        } catch (error) {
-            setTermResults([]);
-            setHasExactMatch(false);
-        } finally {
-            setLoading(false);
-        }
-    }, 500);
+                setTermResults(sortedResults);
+            } catch (error) {
+                setTermResults([]);
+                setHasExactMatch(false);
+            } finally {
+                setLoading(false);
+            }
+        }, 500),
+        []
+    );
 
     const handleSidebarToggle = () => setOpenSidebar(!openSidebar);