From 3831c05595d25b97498143feed5322f911df13f6 Mon Sep 17 00:00:00 2001 From: rayair250-droid Date: Sat, 4 Jul 2026 15:26:04 +0200 Subject: [PATCH] Remove duplicate check_chemistry() calls from stage validators check_chemistry() ran twice per validation: once in validate_common() (called by every stage) and again in validate_simulation/pre_process/post_process. A violated chemistry constraint was therefore reported twice. Remove the three redundant per-stage calls; validate_common() covers all stages. Part (b) of #1509. --- toolchain/mfc/case_validator.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/toolchain/mfc/case_validator.py b/toolchain/mfc/case_validator.py index ca631ba0b6..ba83485bf9 100644 --- a/toolchain/mfc/case_validator.py +++ b/toolchain/mfc/case_validator.py @@ -2267,7 +2267,6 @@ def validate_simulation(self): self.check_continuum_damage() self.check_grcbc() self.check_probe_integral_output() - self.check_chemistry() def validate_pre_process(self): """Validate pre-process-specific parameters""" @@ -2277,7 +2276,6 @@ def validate_pre_process(self): self.check_parallel_io_pre_process() self.check_grid_stretching() self.check_perturb_density() - self.check_chemistry() self.check_misc_pre_process() self.check_patch_physics() self.check_volume_fraction_sum() @@ -2305,7 +2303,6 @@ def validate_post_process(self): self.check_schlieren() self.check_surface_tension_post() self.check_no_flow_variables() - self.check_chemistry() def validate(self, stage: str = "simulation"): """Main validation method