Skip to content

RileyLinks connected LEDs not automatically turned off #2463

Description

@itsmojo

Describe the bug
When setting up a pump using RileyLink, enabling one or more powered up RileyLinks in the RileyLink Setup view will turn on the connected LED on the RileyLink as expected. But if you then cancel out (or continue to the pump view and then switch to another or even the same pump manager), the connected LED on the RileyLink will continue to be on even though the RileyLink is available (i.e., an inconsistent state). If the new (or the same) pump manager also uses RileyLinks, the RileyLink with the connected LED will be listed as available, but its switch will be shown as off (i.e., another inconsistent state). To recover and get the pump manager consistent with the indicated RL state due to its connected LED, toggle the RL switch to on (which will then match the connected LED state). To verify that the app is actually connected, you can toggle the RL switch off and back on again and see that the connected LED is now tracking the switch in the RileyLink Setup view.

Attach an Issue Report
NA

To Reproduce
Steps to reproduce the behavior:

  1. Use Add Pump to select Minimed, Omnipod, or All Omnipod Types (Omnipod Classic). Just a powered up RL with a connected LED is needed, no pod/pump is required.
  2. Advance to the RileyLink Setup view and select one or more powered up RileyLinks and note the connected LED on the corresponding RL is lit.
  3. Cancel out of the pump setup and return to the main view. Note that the RileyLink connection LED is still lit which indicates that it is connected when it really isn't.
  4. Use Add Pump to select the same or different pump type that uses RileyLinks and advance to the RileyLink Setup view again. Note the inconsistent state with the RL having its connected LED lit which indicates it isn't available, but it is listed as being available but not connected.
  5. Toggle the RL switch back and forth and note that it will match toggling action (except for the initial transition that actually connects to the RL that previously incorrectly has its connected LED already lit).

Expected behavior
When a pump manager setup using RileyLinks is canceled out of (or if the user switches pump types) with an enabled RileyLink device with its connected LED turned on, the RileyLink code should automatically turn off the connected LED for all connected RileyLinks that are being released during normal teardown operations to leave the RL connected LED in a consistent state with its actual device state.

Screenshots
NA

Phone

  • Hardware: doesn't matter
  • OS Version: doesn't matter

Loop Version

  • Version Number: doesn't matter
  • Repo: doesn't matter

CGM

  • N/A

Pump

  • Don't need a pump to reproduce, just one or more RileyLinks
  • Pick any pump type that uses a RileyLink (i.e., Minimed or Omnipod Eros [OmniKit or OmnipodKit with Omnipod Classic pods])

Additional context

  • Easy to test using traditional RileyLinks with a solid connected LED.
  • Can be reproduced with either by canceling out of RileyLink Setup view or a pump view with at least one enabled RL, but the former is easier (especially if using MinimedKit) & quicker.

Easier to testing using traditional RileyLinks having a solid connection LED.
Not critical since the RileyLink will actually still be available even though its continued connection LED being led on is inconsistent and potentially confusing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions