Add Annotation makes it hard to interact with existing annotations on dense plots#1225
Merged
Conversation
…d first and the existing annotation glyphs are appended last
labkey-jeckels
approved these changes
Jun 6, 2026
Comment on lines
+2550
to
+2552
| // With many replicates, the "Add annotation" markers can overlap existing annotation | ||
| // glyphs and intercept their hover/click events. Render the add-annotation | ||
| // markers first so the existing annotation glyphs paint on top and take precedence for hovering and clicking. |
Contributor
There was a problem hiding this comment.
We probably don't need this and the comment on line 2641. I'd vote to keep the other.
Contributor
|
Please add a short description to the PR too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/internal-issues/issues/1207 - Annotations on dense plots gets hindered by 'Add Annotation' markers making it difficult to hover or click the annotation to see/modify the details.
Related Pull Requests
Changes