forked from jnode/jnode
-
Notifications
You must be signed in to change notification settings - Fork 0
Port the FAT driver to use ByteBuffer instead of byte arrays #475
Copy link
Copy link
Open
Labels
agent/doneThe agent finished successfully; PR opened or comment posted.The agent finished successfully; PR opened or comment posted.area/fsfs/ — filesystem drivers (FAT, ext2, HFS+, NTFS, ISO9660, ExFAT).fs/ — filesystem drivers (FAT, ext2, HFS+, NTFS, ISO9660, ExFAT).kind/choreRefactor, typo sweep, dead-code removal; no behavior change.Refactor, typo sweep, dead-code removal; no behavior change.
Metadata
Metadata
Assignees
Labels
agent/doneThe agent finished successfully; PR opened or comment posted.The agent finished successfully; PR opened or comment posted.area/fsfs/ — filesystem drivers (FAT, ext2, HFS+, NTFS, ISO9660, ExFAT).fs/ — filesystem drivers (FAT, ext2, HFS+, NTFS, ISO9660, ExFAT).kind/choreRefactor, typo sweep, dead-code removal; no behavior change.Refactor, typo sweep, dead-code removal; no behavior change.
The FAT driver in
fs/src/fs/fat/is using raw byte arrays everywhere —byte[],ByteBuffer.wrap(), manual offset arithmetic, etc. This makes the code hard to read.Can you port it to use
ByteBufferand thejava.nioAPIs more directly? I think this would be a big cleanup.