From 0b0f6f1e7abfcab04e885ef24702b5525bd3b847 Mon Sep 17 00:00:00 2001 From: sid597 Date: Wed, 10 Jun 2026 14:09:21 +0530 Subject: [PATCH 1/2] ENG-1635: Change key image setting from checkbox to toggle switch --- apps/obsidian/src/components/NodeTypeSettings.tsx | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/apps/obsidian/src/components/NodeTypeSettings.tsx b/apps/obsidian/src/components/NodeTypeSettings.tsx index bb7c933af..572c917c0 100644 --- a/apps/obsidian/src/components/NodeTypeSettings.tsx +++ b/apps/obsidian/src/components/NodeTypeSettings.tsx @@ -157,12 +157,14 @@ const BooleanField = ({ onChange: (value: boolean) => void; disabled?: boolean; }) => ( - onChange((e.target as HTMLInputElement).checked)} - disabled={disabled} - /> +
{ + if (!disabled) onChange(!value); + }} + > + +
); const TextField = ({ From 338104ec49867dc63220da78358e673e58d99ef7 Mon Sep 17 00:00:00 2001 From: sid597 Date: Mon, 15 Jun 2026 11:47:04 +0530 Subject: [PATCH 2/2] ENG-1635: Add readOnly to toggle input to suppress React controlled-input warning --- apps/obsidian/src/components/NodeTypeSettings.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/obsidian/src/components/NodeTypeSettings.tsx b/apps/obsidian/src/components/NodeTypeSettings.tsx index 572c917c0..2364e081b 100644 --- a/apps/obsidian/src/components/NodeTypeSettings.tsx +++ b/apps/obsidian/src/components/NodeTypeSettings.tsx @@ -163,7 +163,7 @@ const BooleanField = ({ if (!disabled) onChange(!value); }} > - + );