Skip to content

ci: read Node version from .nvmrc in GitHub workflows (node-version-file) #4919

Description

@NoopDog

Problem

The three GitHub workflows (run-checks.yml, run-playwright-tests-anvil-catalog.yml, run-playwright-tests-anvil-cmg.yml) hard-code node-version: "22.12.0", which has drifted from the repo's pinned Node version — package.json engines.node and .gitlab/Dockerfile are at 22.13.0, and #4918 adds a tracked .nvmrc at 22.13.0.

Proposal

Once #4918 merges, replace the hard-coded version in all three workflows with:

- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
  with:
    node-version-file: ".nvmrc"

This makes .nvmrc the single source of truth for CI and matches the convention already used in clevercanary/hca-atlas-tracker (run-checks.yml there uses node-version-file: ".nvmrc").

A Node version bump then means updating .nvmrc, engines.node, and .gitlab/Dockerfile together — workflows follow automatically.

Also completes the remaining "workflows on 22.13.0" item from #4876.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions