Craft doesn't detect update to items in network

[Nmerryman]

Issue type:

• 🐛 Bug

---

Short description:

I'm back again.
I start a craft and the resulting item is in a chest, visible to the network, but the craft doesn't seem to see it.

Steps to reproduce the problem:

Here is a clip of what happens.
https://cdn.discordapp.com/attachments/802850916759765025/1535921440916906094/Discord_Oa1Qx5RbLi.mp4?ex=6a7985cf&is=6a78344f&hm=edc9432e00cdce1a5b68a7f57236259a814300d5a692a7e36e69100ac8b826aa&

Expected behaviour:

I start the craft, the output is in a chest which the network can see via a storage interface, the item shows up in a terminal, the craft blocks.

---

Versions:

• This mod: While not latest, I looked at the update for the last bug and it seems unrelated.

• Minecraft: 1.21.1
• Mod loader version: NeoForge 1.21.247
• Modpack: Contained Opolis 5.2

Log file:

No messages in log.

[rubensworks]

Thanks for reporting!

[rubensworks]

I can't see your full network in detail, but from the video it looks like you have a separate pipe that runs the crafting result into the chest.
This won't work; you need to use a crafting interface or importer.

To quote the book:

A &lCrafting Interface&r will however &lnot&r import the crafting results from the bound machine. The player is responsible for making sure that the crafting results end up back into the network. The Crafting Table is an exception to this, only a &lCrafting Interface&r is required to craft with this. The &lCrafting Interface&r will track changes in the storage network, and it will only mark the crafting job as completed once the expected outputs are present in the storage network. This can be achieved by either placing an active &lIntegrated Tunnels importer&r onto the machine, or by letting the machine automatically output into the &lCrafting Interface&r. Everything (items, fluids, energy) that is inserted into the &lCrafting Interface&r will be inserted into the storage network for the configured channel.

[Nmerryman]

The book implies that the available inventory is scanned to see if the results are are available so that it can mark the craft as complete. If not, I would suggest adding a line on how completion is checked.
That said, I still get the same issue with an importer.
https://cdn.discordapp.com/attachments/802850916759765025/1536074147170484346/Discord_Vy37QUloO9.mp4?ex=6a7a1407&is=6a78c287&hm=4c5caccfe1dc5ceca24f87b38bdb68e4559edd56968e1e28d8ffe93eab6676b2&
I can find the finished item in one of my storage chests.

[rubensworks]

The book implies that the available inventory is scanned to see if the results are are available so that it can mark the craft as complete. If not, I would suggest adding a line on how completion is checked.

I'm definitely open to improving wording if needed.

That said, I still get the same issue with an importer.

Could you create a minimal reproducible setup and show that one in detail?
The video does not show the full network, so it's possible there are other things happening that may be influencing things.

[Nmerryman]

https://cdn.discordapp.com/attachments/802850916759765025/1536080305159536710/Discord_s8OarC5QeG.mp4?ex=6a7a19c3&is=6a78c843&hm=6c8949018c76b830c7e8d8efc559a626e8619f646654b4e50db0a3c626a12fa0&
I have isolated the network to only only the cables that are visible. The cables end on the right with a few energy exporters, but nothing that should influence the craft.

[rubensworks]

Can you try rebuilding a minimal version of this setup in a creative world (if possible, without other mods installed)?
This is just to rule out the influence of other things.

[Nmerryman]

I wasn't able to reproduce it in single player in the modpack. I do want to point out that this was the only craft that would fail. All other crafters+importers on the network worked fine. Maybe it has something to do with the fact that I'm playing on a server? I also now recall that I had to reset all pending crafts and break/replace a cable when logging in or changing dimensions. I doubt it's related though.

[rubensworks]

Hmm, that's interesting.

Maybe it has something to do with the fact that I'm playing on a server?

There isn't any difference in logic compared to singleplayer/multiplayer.

I also now recall that I had to reset all pending crafts and break/replace a cable when logging in or changing dimensions. I doubt it's related though.

That could be related.
Perhaps there's some chunk corruption happening due to some block within that same chunk.
But those things are notoriously difficult to figure out in a large pack...