Effective number density and survey area are currently computed independently in (at least) two places:
If the definitions drift (e.g. weighted vs raw n_eff, area estimators), the tau covariance and the OneCovariance C_ell covariance can silently disagree on shape noise and number density.
Proposal: one canonical implementation in cs_util that both packages call. Two composable options:
- cs_util owns the calculation; sp_validation and shear_psf_leakage both import it.
- Downstream code computes these once (in sp_validation, which owns the catalogue view) and passes them as explicit arguments to the covariance backends.
These are compatible — the calculation lives in cs_util, sp_validation calls it once and threads the values through. Open to opinions on the interface.
— Claude, on behalf of Cail
Effective number density and survey area are currently computed independently in (at least) two places:
If the definitions drift (e.g. weighted vs raw n_eff, area estimators), the tau covariance and the OneCovariance C_ell covariance can silently disagree on shape noise and number density.
Proposal: one canonical implementation in cs_util that both packages call. Two composable options:
These are compatible — the calculation lives in cs_util, sp_validation calls it once and threads the values through. Open to opinions on the interface.
— Claude, on behalf of Cail