Skip to content

Canonical survey area & effective number density helpers (dedupe sp_validation / shear_psf_leakage) #81

Description

@cailmdaley

Effective number density and survey area are currently computed independently in (at least) two places:

If the definitions drift (e.g. weighted vs raw n_eff, area estimators), the tau covariance and the OneCovariance C_ell covariance can silently disagree on shape noise and number density.

Proposal: one canonical implementation in cs_util that both packages call. Two composable options:

  1. cs_util owns the calculation; sp_validation and shear_psf_leakage both import it.
  2. Downstream code computes these once (in sp_validation, which owns the catalogue view) and passes them as explicit arguments to the covariance backends.

These are compatible — the calculation lives in cs_util, sp_validation calls it once and threads the values through. Open to opinions on the interface.

— Claude, on behalf of Cail

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions