Skip to content

deprecation fix: use new SCSS syntax#2088

Open
mattheworiordan wants to merge 1 commit into
Compass:stablefrom
ably-forks:sass-deprecation-warning-fix
Open

deprecation fix: use new SCSS syntax#2088
mattheworiordan wants to merge 1 commit into
Compass:stablefrom
ably-forks:sass-deprecation-warning-fix

Conversation

@mattheworiordan

@mattheworiordan mattheworiordan commented Jun 8, 2016

Copy link
Copy Markdown

This change fixes the deprecation warning with SASS and fixes issue #2052.

Note, until this PR is merged in, if it ever will be (there are currently 45 open PRs), you can use it simply in your Rails projects by adding the following to your Gemfile:

git 'https://github.com/ably-forks/compass', branch: 'sass-deprecation-warning-fix' do
  gem 'compass-core'
end

The warning this PR fixes is:

DEPRECATION WARNING on line 92 of /Users/mattheworiordan/.rvm/gems/ruby-2.2.2/gems/compass-core-1.0.3/stylesheets/compass/css3/_deprecated-support.scss: #{} interpolation near operators will be simplified
in a future version of Sass. To preserve the current behavior, use quotes:

  unquote('"$ie6-"#{$legacy-support-for-ie6} "$ie7-"#{$legacy-support-for-ie7} "$ie8-"#{$legacy-support-for-ie8}')

Fixes deprecation warning with SASS and Compass#2052

```
DEPRECATION WARNING on line 92 of /Users/mattheworiordan/.rvm/gems/ruby-2.2.2/gems/compass-core-1.0.3/stylesheets/compass/css3/_deprecated-support.scss: #{} interpolation near operators will be simplified
in a future version of Sass. To preserve the current behavior, use quotes:

  unquote('"$ie6-"#{$legacy-support-for-ie6} "$ie7-"#{$legacy-support-for-ie7} "$ie8-"#{$legacy-support-for-ie8}')
```
@mattheworiordan mattheworiordan force-pushed the sass-deprecation-warning-fix branch from b58e1ee to 3861c9d Compare June 8, 2016 16:29
@nsgc

nsgc commented Feb 3, 2017

Copy link
Copy Markdown

Hi @scottdavis, Thanks for maintenance.
I also want this patch.

@julkue

julkue commented Mar 1, 2017

Copy link
Copy Markdown

Why isn't this merged yet?

@dmitry-solomadin

Copy link
Copy Markdown

@julmot because opensource :)

aCandidMind referenced this pull request May 24, 2017
Updated README to inform users Compass is no longer supported.
@aCandidMind

Copy link
Copy Markdown

Just as a note: PR #2094 is a clear indication that compass is no longer supported. I tried to point people in other directions with PR #2124 (e.g. using thoughtbot/bourbon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants