complete Sprint3.1 tasks

Author: JohnRob-jnr

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -47,3 +47,10 @@ function assertEquals(actualOutput, targetOutput) {
 // Example: Identify Right Angles
 const right = getAngleType(90);
 assertEquals(right, "Right angle");
+assertEquals(getAngleType(0), "Invalid angle");
+assertEquals(getAngleType(-1), "Invalid angle");
+assertEquals(getAngleType(360), "Invalid angle");
+assertEquals(getAngleType(45), "Acute angle");
+assertEquals(getAngleType(100), "Obtuse angle");
+assertEquals(getAngleType(180), "Straight angle");
+assertEquals(getAngleType(200), "Reflex angle");

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -17,7 +17,7 @@ function isProperFraction(numerator, denominator) {
 }
 
 
- The line below allows us to load the isProperFraction function into tests in other files.
+//The line below allows us to load the isProperFraction function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
 module.exports = isProperFraction;
 
@@ -34,3 +34,10 @@ function assertEquals(actualOutput, targetOutput) {
 
 // Example: 1/2 is a proper fraction
 assertEquals(isProperFraction(1, 2), true);
+assertEquals(isProperFraction(2, 1), false);
+assertEquals(isProperFraction(2, 4), true);
+assertEquals(isProperFraction(10, 5), false);
+assertEquals(isProperFraction(-1, -2), true);
+assertEquals(isProperFraction(3, 0), false);
+assertEquals(isProperFraction(0, 5), true);
+assertEquals(isProperFraction(3, 3), false);

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -22,9 +22,49 @@
 // execute the code to ensure all tests pass.
 
 function getCardValue(card) {
-  // TODO: Implement this function
+  if (typeof card !== "string" || card.length < 2) {
+    throw new Error("Error: Invalid card format");
+  }
+
+  const rank = card.slice(0, -1);
+  const suit = card.slice(-1);
+  
+  const validSuits = ["♠", "♥", "♦", "♣"];
+  if (!validSuits.includes(suit)) {
+    throw new Error("Error: Invalid suit");
+  }
+
+  switch (rank) {
+    case "A":
+      return 11;
+    case "J":
+    case "Q":
+    case "K":
+      return 10;
+    case "2":
+      return 2;
+    case "3":
+      return 3;
+    case "4":
+      return 4;
+    case "5":
+      return 5;
+    case "6":
+      return 6;
+    case "7":
+      return 7;
+    case "8":
+      return 8;
+    case "9":
+      return 9;
+    case "10":
+      return 10;
+
+  default:
+    throw new Error("Error: Invalid card format");
 }
 
+}
 // The line below allows us to load the getCardValue function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
 module.exports = getCardValue;
@@ -40,8 +80,13 @@ function assertEquals(actualOutput, targetOutput) {
 // TODO: Write tests to cover all outcomes, including throwing errors for invalid cards.
 // Examples:
 assertEquals(getCardValue("9♠"), 9);
+assertEquals(getCardValue("A♠"), 11);
+assertEquals(getCardValue("J♣"), 10);
+assertEquals(getCardValue("Q♦"), 10);
+assertEquals(getCardValue("K♥"), 10);
+assertEquals(getCardValue("2♥"), 2);
+assertEquals(getCardValue("A♠"), 11);
 
-// Handling invalid cards
 try {
   getCardValue("invalid");
 
@@ -52,3 +97,4 @@ try {
 }
 
 // What other invalid card cases can you think of?
+// A) 1♠, 11♠, AA♠, ♠♠, 10  

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -14,7 +14,34 @@ test(`should return "Acute angle" when (0 < angle < 90)`, () => {
 });
 
 // Case 2: Right angle
+test(`should return "Right angle" when angle = 90`, () => {
+  expect(getAngleType(90)).toEqual("Right angle");
+});
+
 // Case 3: Obtuse angles
+test(`should return "Obtuse angle" when (90 < angle < 180)`, () => {
+  expect(getAngleType(91)).toEqual("Obtuse angle");
+  expect(getAngleType(120)).toEqual("Obtuse angle");
+  expect(getAngleType(179)).toEqual("Obtuse angle");
+});
+
 // Case 4: Straight angle
+test(`should return "Straight angle" when angle = 180`, () => {
+  expect(getAngleType(180)).toEqual("Straight angle");
+});
+
 // Case 5: Reflex angles
+test(`should return "Reflex angle" when (180 < angle < 360)`, () => {
+  expect(getAngleType(181)).toEqual("Reflex angle");
+  expect(getAngleType(265)).toEqual("Reflex angle");
+  expect(getAngleType(359)).toEqual("Reflex angle");
+});
+
 // Case 6: Invalid angles
+test(`should return "Invalid angle" when angle is not a number or is outside the valid range`, () => {
+  expect(getAngleType("not a number")).toEqual("Invalid angle");
+  expect(getAngleType(-1)).toEqual("Invalid angle");
+  expect(getAngleType(361)).toEqual("Invalid angle");
+  expect(getAngleType(0)).toEqual("Invalid angle");
+  expect(getAngleType(360)).toEqual("Invalid angle");
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -8,3 +8,29 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 test(`should return false when denominator is zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
 });
+
+
+// (True) - Proper fractions
+test(`should return true when |numerator| < |denominator|`, () => {
+  expect(isProperFraction(1, 2)).toEqual(true);
+  expect(isProperFraction(-1, 2)).toEqual(true);
+  expect(isProperFraction(1, -3)).toEqual(true);
+  expect(isProperFraction(-1, -3)).toEqual(true);
+  expect(isProperFraction(2, 4)).toEqual(true);
+});
+
+// (False) - Improper fractions
+test(`should return false when |numerator| >= |denominator|`, () => {
+  expect(isProperFraction(2, 1)).toEqual(false);
+  expect(isProperFraction(-2, 1)).toEqual(false);
+  expect(isProperFraction(2, -1)).toEqual(false);
+  expect(isProperFraction(-2, -1)).toEqual(false);
+  expect(isProperFraction(3, 3)).toEqual(false);
+});
+
+// (True) - Zero numerator
+test(`should return true when numerator is zero and denominator is non-zero`, () => {
+  expect(isProperFraction(0, 1)).toEqual(true);
+  expect(isProperFraction(0, 5)).toEqual(true);
+  expect(isProperFraction(0, -5)).toEqual(true);
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -11,8 +11,32 @@ test(`Should return 11 when given an ace card`, () => {
 
 // Suggestion: Group the remaining test data into these categories:
 //   Number Cards (2-10)
+test(`Should return the numeric value when given a number card`, () => {
+  expect(getCardValue("2♠")).toEqual(2);
+  expect(getCardValue("10♥")).toEqual(10);
+  expect(getCardValue("7♦")).toEqual(7);
+  expect(getCardValue("5♣")).toEqual(5);
+});
+
 //   Face Cards (J, Q, K)
+test(`Should return 10 when given a face card`, () => {
+  expect(getCardValue("J♣")).toEqual(10);
+  expect(getCardValue("Q♦")).toEqual(10);
+  expect(getCardValue("K♠")).toEqual(10);
+  expect(getCardValue("K♥")).toEqual(10);
+});
+
 //   Invalid Cards
+test(`Should throw an error when given an invalid card`, () => {
+  expect(() => getCardValue("1♠")).toThrow("Error: Invalid card format");
+  expect(() => getCardValue("11♠")).toThrow("Error: Invalid card format");
+  expect(() => getCardValue("AA♠")).toThrow("Error: Invalid card format");
+  expect(() => getCardValue("♠♠")).toThrow("Error: Invalid card format");
+  expect(() => getCardValue("10")).toThrow("Error: Invalid card format");
+  expect(() => getCardValue("A♠♠")).toThrow("Error: Invalid card format");
+  expect(() => getCardValue("0♠")).toThrow("Error: Invalid card format");
+
+});
 
 // To learn how to test whether a function throws an error as expected in Jest,
 // please refer to the Jest documentation: