diff --git a/debugging/book-library/debugging-notes.md b/debugging/book-library/debugging-notes.md
new file mode 100644
index 00000000..fa3945f0
--- /dev/null
+++ b/debugging/book-library/debugging-notes.md
@@ -0,0 +1,61 @@
+# HTML Debugging Checklist
+
+## Page Structure
+
+## Book Input Form
+
+## Add Book Button
+
+## Book Display Area
+
+## Delete Functionality
+
+## Read Status
+
+## Validation Support
+
+## Browser Testing
+
+
+# JavaScript Debugging Checklist
+
+## Library Data Storage
+
+## Page Loading
+
+## Add Book Function
+
+## Book Constructor
+
+## Render Function
+
+## Read/Unread Button
+
+## Delete Button
+
+## Console Errors
+
+
+## Final Testing
+- [ ] Add a book with all information
+- [ ] Add a book without title
+- [ ] Add a book without author
+- [ ] Add a book without pages
+- [ ] Add a read book
+- [ ] Add an unread book
+- [ ] Delete a book
+- [ ] Change read/unread status
+
+# HTML correction:
+- input type
+- submit function
+-
+# Script.js correction:
+- delete e from addEventListener
+- correct book name
+- add input validation for author value in submit() function
+- add author.value replacing title.value in new Book()
+- replace library by myLibrary
+- correct check == true/false and made correction for readstatus = yes/no for read button
+- correct variable name delBut > delButton
+- correct clicks > click
\ No newline at end of file
diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html
index 23acfa71..04a6f8ad 100644
--- a/debugging/book-library/index.html
+++ b/debugging/book-library/index.html
@@ -1,12 +1,9 @@
-
+
-
-
+ Book Library
+
+
@@ -28,10 +25,11 @@
Library
+
+
+
@@ -80,17 +81,9 @@
Library
-
-
-
-
-
-
-
-
-
+
-
+
diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js
index 75ce6c1d..c38712b9 100644
--- a/debugging/book-library/script.js
+++ b/debugging/book-library/script.js
@@ -1,17 +1,39 @@
-let myLibrary = [];
+const titleInput = document.getElementById("title"); //rename all variable names
+const authorInput = document.getElementById("author");
+const pagesInput = document.getElementById("pages");
+const checkInput = document.getElementById("check");
+const bookForm = document.getElementById("bookForm");
+const library = document.getElementById("library"); //newly created id for cleaning all existing row
+const message = document.getElementById("message"); //get element for warning message
-window.addEventListener("load", function (e) {
+const myLibrary = []; //use const to avoid reassignment
+
+/*window.addEventListener("load", function () {
+ //delete e as it is never used
populateStorage();
render();
-});
+}); */
+
+function setup() { // setup () function prepares everything that should happen once
+ // when the page loads and before user starts doing anything
+ bookForm.addEventListener("submit", function (event) { //after user submits the book form
+ // this will run submit () function to add book
+ event.preventDefault();
+ submit();
+ });
+
+ populateStorage();
+}
+
+setup();
function populateStorage() {
if (myLibrary.length == 0) {
- let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
- let book2 = new Book(
+ const book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true); //correct book name
+ const book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
- "127",
+ 127,
true
);
myLibrary.push(book1);
@@ -20,27 +42,32 @@ function populateStorage() {
}
}
-const title = document.getElementById("title");
-const author = document.getElementById("author");
-const pages = document.getElementById("pages");
-const check = document.getElementById("check");
//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
+ const title = titleInput.value.trim(); //use .trim() to remove extra spaces
+ const author = authorInput.value.trim();
+ const pages = Number(pagesInput.value);
if (
- title.value == null ||
- title.value == "" ||
- pages.value == null ||
- pages.value == ""
+ title === "" ||
+
+ author === "" || //need input validation for author value, added this
+
+ pagesInput.value === ""
) {
alert("Please fill all fields!");
return false;
- } else {
- let book = new Book(title.value, title.value, pages.value, check.checked);
- library.push(book);
- render();
}
+ if (pages < 1) {
+ alert("Pages must be at least 1!");
+ return false;
+ }
+
+ const book = new Book(title, author, pages, checkInput.checked); //added author.value by
+ // replacing 2nd title.value to author.value
+ myLibrary.push(book); //corrected name for original array library > myLibrary
+ render();
}
function Book(title, author, pages, check) {
@@ -51,53 +78,57 @@ function Book(title, author, pages, check) {
}
function render() {
- let table = document.getElementById("display");
- let rowsNumber = table.rows.length;
- //delete old table
- for (let n = rowsNumber - 1; n > 0; n-- {
- table.deleteRow(n);
- }
+ // delete all old row at once
+
+ library.innerHTML = ""; //clean all old rows
+
//insert updated row and cells
- let length = myLibrary.length;
+ const length = myLibrary.length;
for (let i = 0; i < length; i++) {
- let row = table.insertRow(1);
- let titleCell = row.insertCell(0);
- let authorCell = row.insertCell(1);
- let pagesCell = row.insertCell(2);
- let wasReadCell = row.insertCell(3);
- let deleteCell = row.insertCell(4);
- titleCell.innerHTML = myLibrary[i].title;
- authorCell.innerHTML = myLibrary[i].author;
- pagesCell.innerHTML = myLibrary[i].pages;
+ const row = library.insertRow();
+ const titleCell = row.insertCell(0);
+ const authorCell = row.insertCell(1);
+ const pagesCell = row.insertCell(2);
+ const wasReadCell = row.insertCell(3);
+ const deleteCell = row.insertCell(4);
+ titleCell.textContent = myLibrary[i].title; // replaced all innerHTML by textContent
+ authorCell.textContent = myLibrary[i].author;
+ pagesCell.textContent = myLibrary[i].pages;
//add and wait for action for read/unread button
- let changeBut = document.createElement("button");
- changeBut.id = i;
- changeBut.className = "btn btn-success";
- wasReadCell.appendChild(changeBut);
- let readStatus = "";
- if (myLibrary[i].check == false) {
- readStatus = "Yes";
- } else {
- readStatus = "No";
- }
- changeBut.innerText = readStatus;
-
- changeBut.addEventListener("click", function () {
+ const changeButton = document.createElement("button"); //correct changeBut > changeButton
+ changeButton.className = "btn btn-success";
+ wasReadCell.appendChild(changeButton);
+ const readStatus = myLibrary[i].check ? "Yes" : "No";
+ changeButton.textContent = readStatus;
+ changeButton.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});
+
+
//add delete button to every row and render again
- let delButton = document.createElement("button");
- delBut.id = i + 5;
- deleteCell.appendChild(delBut);
- delBut.className = "btn btn-warning";
- delBut.innerHTML = "Delete";
- delBut.addEventListener("clicks", function () {
- alert(`You've deleted title: ${myLibrary[i].title}`);
- myLibrary.splice(i, 1);
- render();
- });
+ let deleteButton = document.createElement("button");
+ deleteCell.appendChild(deleteButton);
+ deleteButton.className = "btn btn-warning";
+ deleteButton.textContent = "Delete";
+ deleteButton.addEventListener("click", function () {
+ // correct clicks > click
+ const deletedTitle = myLibrary[i].title; // store the title which book will delete
+
+ const confirmed = confirm( //use confirm () to handle popup message for ok/cancel
+ `Are you sure you want to delete "${deletedTitle}"?`
+ );
+
+ if (confirmed) { //if confirm then user click ok and book will delete
+ myLibrary.splice(i, 1);
+ render(); //updates page
+
+ message.textContent = `Book "${deletedTitle}" was deleted.`; //after clicking ok, th book delete
+ // and the message shows immediately
+ }
+ });
}
+
}