add choices for get_prod_info and check_xgrade

Author: vdloo

hypernode_api_python/commands.py

@@ -379,9 +379,13 @@ def get_product_info(args=None):
 """,
         formatter_class=RawTextHelpFormatter,
     )
-    parser.add_argument("product_code", help="The code of the product to get")
-    args = parser.parse_args(args=args)
     client = get_client()
+    parser.add_argument(
+        "product_code",
+        help="The code of the product to get",
+        choices=[p["code"] for p in client.get_active_products().json()],
+    )
+    args = parser.parse_args(args=args)
     print_response(client.get_product_info_with_price(args.product_code))
 
 
@@ -575,8 +579,12 @@ def check_xgrade(args=None):
 """,
         formatter_class=RawTextHelpFormatter,
     )
-    parser.add_argument("product_code", help="The code of the product to check")
-    args = parser.parse_args(args=args)
     client = get_client()
+    parser.add_argument(
+        "product_code",
+        help="The code of the product to check",
+        choices=[p["code"] for p in client.get_active_products().json()],
+    )
+    args = parser.parse_args(args=args)
     app_name = get_app_name()
     print_response(client.check_xgrade(app_name, args.product_code))

tests/commands/test_check_xgrade.py

@@ -13,6 +13,14 @@ def setUp(self):
             "hypernode_api_python.commands.get_app_name"
         )
         self.get_app_name.return_value = "myappname"
+        self.client.get_active_products.return_value.json.return_value = [
+            {
+                "code": "FALCON_S_202203",
+            },
+            {
+                "code": "JACKAL_M_202201",
+            },
+        ]
 
     def test_check_xgrade_gets_client(self):
         check_xgrade(["FALCON_S_202203"])
@@ -35,3 +43,7 @@ def test_check_xgrade_prints_product(self):
         self.print_response.assert_called_once_with(
             self.client.check_xgrade.return_value
         )
+
+    def test_check_xgrade_raises_if_product_not_found(self):
+        with self.assertRaises(SystemExit):
+            check_xgrade(["ProductThatDoesNotExist"])

tests/commands/test_get_product_info.py

@@ -9,6 +9,14 @@ def setUp(self):
         )
         self.get_client = self.set_up_patch("hypernode_api_python.commands.get_client")
         self.client = self.get_client.return_value
+        self.client.get_active_products.return_value.json.return_value = [
+            {
+                "code": "FALCON_S_202203",
+            },
+            {
+                "code": "JACKAL_M_202201",
+            },
+        ]
 
     def test_get_product_info_gets_client(self):
         get_product_info(["FALCON_S_202203"])
@@ -28,3 +36,7 @@ def test_get_product_info_prints_product(self):
         self.print_response.assert_called_once_with(
             self.client.get_product_info_with_price.return_value
         )
+
+    def test_get_product_raises_if_product_not_found(self):
+        with self.assertRaises(SystemExit):
+            get_product_info(["ProductThatDoesNotExist"])