Commit 5761392
committed
report: say which Zcash shielded tests never touch a device
Chasing a rendering defect on the per-output shielded confirm turned up
something worse than a missing screenshot: ZcashSignPCZT is never sent to a
device anywhere in this suite. Every test in test_msg_zcash_sign_pczt drives
a ScriptedTransport with canned responses -- they are offline contract tests
that prove the client builds and orders its messages correctly, and prove
nothing whatsoever about firmware behaviour.
The device-driven Zcash tests cover transparent signing, display-address,
FVK derivation and the seed fingerprint. None of them signs a shielded
output. So the on-device shielded path -- including the confirm screen that
fsm_msg_zcash.h designates as the verification gate for Orchard output
values, since total_amount is "a summary prompt" taken from the host -- has
no automated coverage at all.
The catalog gave no hint of this. The section Z entries read exactly like
the device tests around them, and that is how a screen nobody has ever
rendered sat behind seven green checks.
Say it in the entry instead. No screenshot hint: requesting frames from a
test that cannot reach a device would produce silently zero of them, which
is the same class of empty-but-green evidence this whole pass exists to
remove.
Verified: --screenshot-filter does not select it, and the report still
renders 325 tests and passes --validate-junit against the RC artifacts.1 parent 74768b0 commit 5761392
1 file changed
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2038 | 2038 | | |
2039 | 2039 | | |
2040 | 2040 | | |
2041 | | - | |
| 2041 | + | |
| 2042 | + | |
| 2043 | + | |
| 2044 | + | |
| 2045 | + | |
| 2046 | + | |
| 2047 | + | |
| 2048 | + | |
2042 | 2049 | | |
2043 | 2050 | | |
2044 | 2051 | | |
| |||
0 commit comments