refactor(abstract-utxo): eliminate fetchInputs by reusing explainPsbtWasm inputAmount

The legacy getTxInputs branch is unreachable (decodeTransaction throws
ErrorDeprecatedTxFormat for non-PSBT input), and getPsbtTxInputs's only
remaining caller in verifyTransaction just sums input values to check
fee >= 0. explainPsbtWasm already returns inputAmount, so reuse that
and delete fetchInputs.ts entirely.

Refs: T1-3279

Author: OttoAllmendinger

modules/abstract-utxo/src/transaction/fetchInputs.ts

@@ -5,11 +5,9 @@ import { BitGoBase, TxIntentMismatchError, IBaseCoin } from '@bitgo/sdk-core';
 import { hasPsbtMagic } from '@bitgo/wasm-utxo';
 
 import { AbstractUtxoCoin, VerifyTransactionOptions } from '../../abstractUtxoCoin';
-import { Output, ParsedTransaction } from '../types';
-import { toTNumber } from '../../tnumber';
+import { ParsedTransaction } from '../types';
 import { stringToBufferTryFormats } from '../decode';
 import { verifyCustomChangeKeySignatures, verifyKeySignature, verifyUserPublicKeyAsync } from '../../verifyKey';
-import { getPsbtTxInputs, getTxInputs } from '../fetchInputs';
 
 const debug = buildDebug('bitgo:abstract-utxo:verifyTransaction');
 
@@ -201,29 +199,9 @@ export async function verifyTransaction<TNumber extends bigint | number>(
     }
   }
 
-  const allOutputs = parsedTransaction.outputs;
   if (!txPrebuild.txHex) {
     throw new Error(`txPrebuild.txHex not set`);
   }
-  const inputs = isPsbt
-    ? getPsbtTxInputs(txPrebuild.txHex, coin.name).map((v) => ({
-        ...v,
-        value: toTNumber(v.value, coin.amountType),
-      }))
-    : await getTxInputs({ txPrebuild, bitgo, coin, disableNetworking, reqId });
-  // coins (doge) that can exceed number limits (and thus will use bigint) will have the `valueString` field
-  const inputAmount = inputs.reduce(
-    (sum: bigint, i) => sum + BigInt(coin.amountType === 'bigint' ? i.valueString : i.value),
-    BigInt(0)
-  );
-  const outputAmount = allOutputs.reduce((sum: bigint, o: Output) => sum + BigInt(o.amount), BigInt(0));
-  const fee = inputAmount - outputAmount;
-
-  if (fee < 0) {
-    throw new Error(
-      `attempting to spend ${outputAmount} satoshis, which exceeds the input amount (${inputAmount} satoshis) by ${-fee}`
-    );
-  }
 
   return true;
 }

modules/abstract-utxo/src/transaction/fixedScript/verifyTransaction.ts

@@ -3,7 +3,6 @@ export * from './recipient';
 export { explainTx } from './explainTransaction';
 export { parseTransaction } from './parseTransaction';
 export { verifyTransaction } from './verifyTransaction';
-export * from './fetchInputs';
 export * as bip322 from './bip322';
 export { decodePsbt } from './decode';
 export * from './fixedScript';