Skip to content

Remove tinyxml2 vendor on rolling #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mini-1235 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Remove tinyxml2 vendor on rolling #1135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
55edd39
Remove tinyxml2 vendor on rolling
mini-1235 Apr 29, 2026
cde8f2d
Make tinyxml2_vendor quiet
mini-1235 Apr 29, 2026
69d8304
Merge branch 'master' into fix/tinyxml2
mini-1235 Jun 1, 2026
52d93c7
ci: retrigger
mini-1235 Jun 1, 2026
a1c2c78
Update to testing rolling
mini-1235 Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ros2-rolling.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
matrix:
env:
- {ROS_DISTRO: rolling, ROS_REPO: main}
- {ROS_DISTRO: rolling, ROS_REPO: testing}

@mini-1235 mini-1235 Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that the ROS PMC is considering dropping support for the main repository in favor of the testing repository only for Rolling. The CI was failing earlier because there were no syncs for Rolling on 26.04, switching to the testing repo fixed it. Thoughts on this change? @facontidavide

Related:

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ if ( ament_cmake_FOUND )
message(STATUS "------------------------------------------")
include(cmake/ament_build.cmake)

find_package(tinyxml2_vendor REQUIRED)
find_package(tinyxml2_vendor QUIET)
find_package(TinyXML2 REQUIRED)
else()
message(STATUS "------------------------------------------")
Expand Down
4 changes: 2 additions & 2 deletions package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@

<depend>libsqlite3-dev</depend>
<depend>libzmq3-dev</depend>
<depend>tinyxml2</depend>
<depend>tinyxml2_vendor</depend>
<depend condition="$ROS_DISTRO != humble and $ROS_DISTRO != jazzy and $ROS_DISTRO != kilted">tinyxml2</depend>
<depend condition="$ROS_DISTRO == humble or $ROS_DISTRO == jazzy or $ROS_DISTRO == kilted">tinyxml2_vendor</depend>

<test_depend >ament_cmake_gtest</test_depend>

Expand Down
Loading