update enhanced ff filter parameter handling with classic

Author: linglingye001

src/featureManagement/featureFlagConverter.ts

@@ -26,7 +26,7 @@ export function convert(featureFlag: AzAppConfigFeatureFlag): FeatureFlag {
                 const clientFilter: FeatureFilter = { name: filter.name };
                 if (filter.parameters != null) {
                     clientFilter.parameters = Object.fromEntries(
-                        Object.entries(filter.parameters).map(([name, value]) => [name, parseParameterValue(value, featureFlag.name)]));
+                        Object.entries(filter.parameters).map(([name, value]) => [name, parseJsonValue(value, featureFlag.name)]));
                 }
                 return clientFilter;
             })
@@ -94,15 +94,6 @@ export function convert(featureFlag: AzAppConfigFeatureFlag): FeatureFlag {
     return result;
 }
 
-function parseParameterValue(value: string, featureFlagName: string): unknown {
-    const trimmedValue = value.trim();
-    if (trimmedValue.length > 0 && (trimmedValue[0] === "{" || trimmedValue[0] === "[")) {
-        return parseJsonValue(value, featureFlagName);
-    }
-
-    return value;
-}
-
 function parseJsonValue(value: string, featureFlagName: string): unknown {
     try {
         return JSON.parse(value) as unknown;

test/featureFlag.test.ts

@@ -569,7 +569,7 @@ describe("enhanced feature flags", function () {
                         parameters: {
                             Audience: JSON.stringify(audience),
                             JsonArray: "  [\"one\",\"two\"]  ",
-                            PlainText: "not-json",
+                            PlainText: JSON.stringify("not-json"),
                             Percentage: "50"
                         }
                     }]
@@ -587,7 +587,7 @@ describe("enhanced feature flags", function () {
         expect(parameters.Audience).deep.equals(audience);
         expect(parameters.JsonArray).deep.equals(["one", "two"]);
         expect(parameters.PlainText).equals("not-json");
-        expect(parameters.Percentage).equals("50");
+        expect(parameters.Percentage).equals(50);
     });
 
     it("should throw for invalid JSON in enhanced feature flag filter parameters", () => {
@@ -651,7 +651,7 @@ describe("enhanced feature flags", function () {
         const enhancedFeatureFlag = createMockedEnhancedFeatureFlag("Variant", {
             conditions: {
                 requirementType: "All",
-                filters: [{ name: "Microsoft.TimeWindow", parameters: { Start: "Mon, 01 Jan 2024 00:00:00 GMT" } }]
+                filters: [{ name: "Microsoft.TimeWindow", parameters: { Start: JSON.stringify("Mon, 01 Jan 2024 00:00:00 GMT") } }]
             },
             variants: [
                 { name: "Off", value: false, statusOverride: "Disabled" },