Merge branch 'AliceO2Group:master' into LambdaPolRing-v3

Author: cmuncinelli

.clang-tidy

@@ -111,6 +111,8 @@ WarningsAsErrors: >-
   *,
   -readability-braces-around-statements,
   -readability-suspicious-call-argument,
+  -modernize-*,
+  -readability-*,
 CheckOptions:
   modernize-avoid-c-arrays.AllowStringArrays: true
   # Common tolerated conversions

CMakeLists.txt

@@ -9,7 +9,10 @@
 # granted to it by virtue of its status as an Intergovernmental Organization
 # or submit itself to any jurisdiction.
 
-cmake_minimum_required(VERSION 3.23 FATAL_ERROR)
+# 3.27 for $<COMPILE_ONLY:>, which O2PhysicsAddWorkflow.cmake uses to give a
+# workflow the precompiled header carrier's compile usage requirements without
+# also putting it on the link line. Builds use CMake 4.1 (alidist cmake.sh).
+cmake_minimum_required(VERSION 3.27 FATAL_ERROR)
 
 project(O2Physics
         VERSION 0.0.1

Common/Core/CMakeLists.txt

@@ -30,8 +30,12 @@ o2physics_add_library(AnalysisCore
 # Skipped under recc, which caches compilations remotely instead -- the two do
 # not combine, as a PCH is a local artefact of one compiler invocation.
 #
-# The link libraries have to match what the reusing targets compile with, so
-# this carries only what every workflow already links.
+# The reusing targets must compile with the same preprocessor state as this
+# carrier, which does not follow from the link list: AnalysisCore reaches
+# O2::rANS and its INTERFACE -DRANS_ENABLE_JSON, whereas a bare workflow links
+# only O2::Framework. o2physics_add_dpl_workflow therefore copies this target's
+# compile definitions onto every consumer; keep that in mind when changing what
+# is linked here.
 add_library(AnalysisPCH OBJECT analysisPCH.cxx)
 target_link_libraries(AnalysisPCH PUBLIC O2::Framework O2Physics::AnalysisCore)
 if(NOT DEFINED ENV{USE_RECC})